Skip to content

Add system Nexus signal-with-start workflow API#744

Merged
jmaeagle99 merged 17 commits into
mainfrom
nexus-api-gen-signal-with-start
Jul 10, 2026
Merged

Add system Nexus signal-with-start workflow API#744
jmaeagle99 merged 17 commits into
mainfrom
nexus-api-gen-signal-with-start

Conversation

@tconley1428

Copy link
Copy Markdown
Contributor

Summary

  • generate system Nexus workflow APIs from temporary WIT during the SDK build
  • expose generated operations from the Workflow partial class without checking generated C# into source
  • handle system Nexus envelopes with binary protobuf outer payloads and generated nested payload traversal for codecs
  • add a focused workflow test for signal-with-start from workflow with a payload codec

Testing

  • dotnet build src/Temporalio/Temporalio.csproj -f netstandard2.0 -clp:ErrorsOnly -v:q
  • dotnet test tests/Temporalio.Tests/Temporalio.Tests.csproj --filter FullyQualifiedName~ExecuteWorkflowAsync_SignalWithStartFromWorkflow_Succeeds -clp:ErrorsOnly -v:n

Comment thread src/Temporalio.SystemNexus.Generator/wit/deps/nexus-temporal-types/model.wit Outdated
Comment thread src/Temporalio/SystemNexus/Generated/Service.cs Outdated
Comment thread src/Temporalio/Workflows/Generated/Models.cs
Comment thread src/Temporalio/SystemNexus/Generated/Operations.cs Outdated
Comment thread src/Temporalio.SystemNexus.Generator/Temporalio.SystemNexus.Generator.csproj Outdated
Comment thread src/Temporalio.SystemNexus.Generator/Temporalio.SystemNexus.Generator.csproj Outdated
Comment thread src/Temporalio.SystemNexus.Generator/Program.cs
Comment thread src/Temporalio.SystemNexus.Generator/Program.cs Outdated
Comment thread src/Temporalio.SystemNexus.Generator/Program.cs Outdated
@jmaeagle99 jmaeagle99 self-assigned this Jun 22, 2026
@tconley1428 tconley1428 marked this pull request as ready for review June 23, 2026 22:33
@tconley1428 tconley1428 requested a review from a team as a code owner June 23, 2026 22:33

@jmaeagle99 jmaeagle99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would ask that the ExpressionUtil forward and marking public methods / types as experimental are done before merging. Adding GeneratedCode attribute would be nice, but can be deferred.

Comment thread src/Temporalio/Workflows/Generated/Operations.cs
Comment thread src/Temporalio/Workflows/Generated/Operations.cs
Comment thread src/Temporalio/Workflows/Generated/Models.cs
Comment thread src/Temporalio/Workflows/Generated/Operations.cs
Comment thread src/Temporalio/Worker/Generated/SystemNexusPayloadVisitor.cs
@jmaeagle99 jmaeagle99 merged commit 7efa087 into main Jul 10, 2026
15 checks passed
@jmaeagle99 jmaeagle99 deleted the nexus-api-gen-signal-with-start branch July 10, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants